Remove NullPointerException.

Remove NullPointerException.

Accessing non-existing members on null now throws NoSuchMethodError.
Throwing a null value fails by throwing a NullThrownError.
Methods checking for null now generally throw new ArgumentError(null).

Committed: https://code.google.com/p/dart/source/detail?r=15061

Committed: https://code.google.com/p/dart/source/detail?r=15136

[ngeoffray, 2012-11-16 12:41:30]

dart2js changes LGTM

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:754: // a
NoSuchMethodError
Keep the '.' at the end.

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/core/map.dart
File sdk/lib/core/map.dart (right):

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/core/map.dart#newc...
sdk/lib/core/map.dart:192: if (key == null) throw new ArgumentError(null);
new or const?

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/core/map.dart#newc...
sdk/lib/core/map.dart:227: if (key == null) throw const ArgumentError(null);
new or const?

[Lasse Reichstein Nielsen, 2012-11-16 15:32:23]

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/optimize.dart (right):

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/optimize.dart:754: // a
NoSuchMethodError
Well spotted!

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/core/map.dart
File sdk/lib/core/map.dart (right):

https://codereview.chromium.org/11415028/diff/3001/sdk/lib/core/map.dart#newc...
sdk/lib/core/map.dart:227: if (key == null) throw const ArgumentError(null);
Should be "new". There shouldn't even be a const constructor on ArgumentError,
so I'll check if this is the reason for some of the co19 errors.

[floitsch, 2012-11-16 16:38:44]

LGTM.

https://codereview.chromium.org/11415028/diff/3001/tests/language/null_pointe...
File tests/language/null_pointer_exception_test.dart (right):

https://codereview.chromium.org/11415028/diff/3001/tests/language/null_pointe...
tests/language/null_pointer_exception_test.dart:5: class NullAccessTest {
rename file.

https://codereview.chromium.org/11415028/diff/3001/tests/language/string_inte...
File tests/language/string_interpolate_npe_test.dart (right):

https://codereview.chromium.org/11415028/diff/3001/tests/language/string_inte...
tests/language/string_interpolate_npe_test.dart:5: 
rename test.

[floitsch, 2012-11-16 16:38:45]

LGTM.

[Lasse Reichstein Nielsen, 2012-11-19 15:02:48]

This crashes in the VM X64 build. Any ideas why?

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/regexp.cc
File runtime/lib/regexp.cc (left):

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/regexp.cc#old...
runtime/lib/regexp.cc:27: CheckAndThrowExceptionIfNull(arg1);
Was this code actually necessary to test for getting zero arguments?

[regis, 2012-11-19 19:45:31]

LGTM

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/object.cc#new...
runtime/lib/object.cc:29: Exceptions::ThrowByType(Exceptions::kNullThrown,
args);
We called a method on null. Is NullThrown the right exception to throw? I would
have expected a NoSuchMethodError with null as receiver.

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/regexp.cc
File runtime/lib/regexp.cc (left):

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/regexp.cc#old...
runtime/lib/regexp.cc:27: CheckAndThrowExceptionIfNull(arg1);
On 2012/11/19 15:02:48, Lasse Reichstein Nielsen wrote:
> Was this code actually necessary to test for getting zero arguments?

I am not familiar with this code. The first argument, NativeArgAt(0), to the
factory is the type argument vector. In this case, we check that it is null,
because JSSyntaxRegExp is not generic.

The second argument, NativeArgAt(1), is checked for null. I have no idea why.
This would only make sense if the Jscre::Compile call cannot handle a null
pattern.

[Lasse Reichstein Nielsen, 2012-11-20 09:21:11]

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/object.cc
File runtime/lib/object.cc (right):

https://codereview.chromium.org/11415028/diff/10001/runtime/lib/object.cc#new...
runtime/lib/object.cc:29: Exceptions::ThrowByType(Exceptions::kNullThrown,
args);
Noooo, kNullThrown is wrong! We should just fall through and throw a
noSuchMethodError the usual way.
This, and another similar error was indeed the problem - kNullThrown doesn't
take two arguments!

[ahe, 2013-01-29 17:17:10]

https://codereview.chromium.org/11415028/diff/5003/tests/compiler/dart2js_nat...
File tests/compiler/dart2js_native/dart2js_native.status (right):

https://codereview.chromium.org/11415028/diff/5003/tests/compiler/dart2js_nat...
tests/compiler/dart2js_native/dart2js_native.status:9:
native_null_closure_frog_test: Fail
I'd appreciate if you would file a bug when you mark tests as failing.