Issue 11415027: Refactor the HTTP parser to collect headers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11415027: Refactor the HTTP parser to collect headers (Closed)

Created:
8 years, 1 month ago by Søren Gjesse

Modified:
8 years, 1 month ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor the HTTP parser to collect headers The headers are now collected directly in the HTTP parser instead of it emitting events for each header line parsed. One event (request or response) is now emitted when the full header is parsed. Had to move the HTTP header object implementation for this change. Also included a changing the request/response state constants to static constants instead of final fields. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15002

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addessed review comments #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -771 lines)			Patch
M	sdk/lib/io/http_impl.dart	View	1	20 chunks	+87 lines, -725 lines	0 comments	Download
M	sdk/lib/io/http_parser.dart	View		10 chunks	+28 lines, -22 lines	0 comments	Download
M	sdk/lib/io/iolib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/http_headers_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/io/http_parser_test.dart	View		9 chunks	+32 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

lgtm https://codereview.chromium.org/11415027/diff/1/sdk/lib/io/http_impl.dart File sdk/lib/io/http_impl.dart (right): https://codereview.chromium.org/11415027/diff/1/sdk/lib/io/http_impl.dart#newcode79 sdk/lib/io/http_impl.dart:79: static const HEADER_SENT = 1; Accidentally dropped the ...

8 years, 1 month ago (2012-11-16 09:36:33 UTC) #2

Søren Gjesse

8 years, 1 month ago (2012-11-16 09:43:05 UTC) #3

https://codereview.chromium.org/11415027/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/11415027/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:79: static const HEADER_SENT = 1;
On 2012/11/16 09:36:33, Mads Ager wrote:
> Accidentally dropped the 'int' type here.

Done.

Expand Messages | Collapse Messages