Issue 11414293: Fix a number of int type issues in dart:io File implementation to avoid implicit conversions that c…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414293: Fix a number of int type issues in dart:io File implementation to avoid implicit conversions that c… (Closed)

Created:
8 years ago by Mads Ager (google)

Modified:
8 years ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix a number of int type issues in dart:io File implementation to avoid implicit conversions that can change the value. R=sgjesse@google.com BUG=dartbug.com/5301 Committed: https://code.google.com/p/dart/source/detail?r=15635

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -68 lines)			Patch
M	runtime/bin/builtin_natives.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/dartutils.h	View	3 chunks	+7 lines, -2 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/bin/file.cc	View	23 chunks	+54 lines, -64 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm