Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 11414258: Reapply dart2js: Dot-separated field-and-super descriptor string in classes. (Closed)

Created:
8 years ago by erikcorry
Modified:
8 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply dart2js: Dot-separated field-and-super descriptor string in classes. But now we comma-separate the fields, and use semicolon instead of @ for the super class (because it's smaller!). R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -47 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart View 6 chunks +43 lines, -33 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart View 1 chunk +3 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/class_codegen_test.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/no_constructor_body_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/no_duplicate_constructor_body_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
erikcorry
8 years ago (2012-11-30 13:25:19 UTC) #1
karlklose
8 years ago (2012-11-30 13:29:43 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698