Issue 11414195: Make #maxRedirects and #followRedirects work for the dart:io HTTP client.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414195: Make #maxRedirects and #followRedirects work for the dart:io HTTP client. (Closed)

Created:
8 years ago by nweiz

Modified:
8 years ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org, Søren Gjesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make #maxRedirects and #followRedirects work for the dart:io HTTP client. Committed: https://code.google.com/p/dart/source/detail?r=15433

Patch Set 1 #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -2 lines)			Patch
M	pkg/http/lib/src/io_client.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/http/test/request_test.dart	View	1 chunk	+47 lines, -0 lines	1 comment	Download
M	pkg/http/test/utils.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years ago (2012-11-28 01:50:18 UTC) #2

LGTM.

https://codereview.chromium.org/11414195/diff/1/pkg/http/test/request_test.dart
File pkg/http/test/request_test.dart (right):

https://codereview.chromium.org/11414195/diff/1/pkg/http/test/request_test.da...
pkg/http/test/request_test.dart:202: ..followRedirects = false;
How about not using a cascade here. Or, if you must, indent it 2 more?

Expand Messages | Collapse Messages