Issue 11414144: Increase the heap growth rate as it decreases compile-time by as much as 10%.

Issue 11414144: Increase the heap growth rate as it decreases compile-time by as much as 10%. (Closed)

Created:
8 years ago by ahe

Modified:
8 years ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Increase the heap growth rate as it decreases compile-time by as much as 10%. Committed: https://code.google.com/p/dart/source/detail?r=15377

Patch Set 2 : Address review comments #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	dart/utils/compiler/build_helper.dart	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_helper.dart#newcode97 dart/utils/compiler/build_helper.dart:97: // TODO(ahe): Remove this option. Please also mention ...

8 years ago (2012-11-27 09:07:37 UTC) #2

ahe

Thank you, Nicolas! https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_helper.dart File dart/utils/compiler/build_helper.dart (right): https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_helper.dart#newcode97 dart/utils/compiler/build_helper.dart:97: // TODO(ahe): Remove this option. On ...

8 years ago (2012-11-27 09:53:28 UTC) #3

dgrove

8 years ago (2012-11-27 16:16:09 UTC) #4

Message was sent while issue was closed.

Hi Peter-

Can you also please change the scripts in sdk/bin/ ? The scripts we use in the
shipped sdk are actually copies from sdk/bin, not from build_helper.dart (which
we need to get rid of soon)

On 2012/11/27 09:53:28, ahe wrote:
> Thank you, Nicolas!
> 
>
https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_hel...
> File dart/utils/compiler/build_helper.dart (right):
> 
>
https://codereview.chromium.org/11414144/diff/1/dart/utils/compiler/build_hel...
> dart/utils/compiler/build_helper.dart:97: // TODO(ahe): Remove this option.
> On 2012/11/27 09:07:37, ngeoffray wrote:
> > Please also mention the bug number.
> 
> Done.

Expand Messages | Collapse Messages