Removing duplicated events.

Removing duplicated events.

Document and DocumentFragment events derive from ElementEvents, but our generation wasn't really accounting for it.

BUG=5414
Committed: https://code.google.com/p/dart/source/detail?r=15350

[sra1, 2012-11-21 05:35:09]

https://codereview.chromium.org/11414096/diff/1/sdk/lib/html/scripts/htmleven...
File sdk/lib/html/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/11414096/diff/1/sdk/lib/html/scripts/htmleven...
sdk/lib/html/scripts/htmleventgenerator.py:202: # Document and DocumentFragment
actually derive from Element, so omit
I think it would be better to walk the parent interface chain looking for the
same event attributes.  E.g. BodyElementEvents has a duplicated 'focus' event.

i.e. events = set([attr for attr in interface.attributes if attr.type.id ==
'EventListener' and not _FindShadowedAttribute(attr, interface)])

You might need to pull out FindShadowedAttribute from somewhere.

[blois, 2012-11-26 17:23:18]

https://codereview.chromium.org/11414096/diff/1/sdk/lib/html/scripts/htmleven...
File sdk/lib/html/scripts/htmleventgenerator.py (right):

https://codereview.chromium.org/11414096/diff/1/sdk/lib/html/scripts/htmleven...
sdk/lib/html/scripts/htmleventgenerator.py:202: # Document and DocumentFragment
actually derive from Element, so omit
On 2012/11/21 05:35:09, sra1 wrote:
> I think it would be better to walk the parent interface chain looking for the
> same event attributes.  E.g. BodyElementEvents has a duplicated 'focus' event.
> 
> i.e. events = set([attr for attr in interface.attributes if attr.type.id ==
> 'EventListener' and not _FindShadowedAttribute(attr, interface)])
> 
> You might need to pull out FindShadowedAttribute from somewhere.

Yeah, I tried that approach first- they are actually not in the parent interface
chain. See 'ugly hack' in _GetParentEventsClassName.

[sra1, 2012-11-26 22:44:06]

lgtm