Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 11414093: Source maps - JSON strings need double quotes. (Closed)

Created:
8 years, 1 month ago by sra1
Modified:
8 years ago
Reviewers:
erikcorry, ahe
CC:
reviews_dartlang.org, ahe
Visibility:
Public.

Description

Single quotes are not legal JSON. TBR Committed: https://code.google.com/p/dart/source/detail?r=15183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sra1
8 years, 1 month ago (2012-11-20 23:05:44 UTC) #1
ahe
Erik, weren't you doing something even more ambitious with this? Cheers, Peter
8 years ago (2012-11-22 16:26:13 UTC) #2
erikcorry
On 2012/11/22 16:26:13, ahe wrote: > Erik, weren't you doing something even more ambitious with ...
8 years ago (2012-11-22 16:29:44 UTC) #3
erikcorry
On 2012/11/22 16:29:44, erikcorry wrote: > On 2012/11/22 16:26:13, ahe wrote: > > Erik, weren't ...
8 years ago (2012-11-22 16:30:15 UTC) #4
ahe
8 years ago (2012-11-22 17:29:17 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698