Issue 11414064: Ignore functions that have the same name as fields in gets and sets.

Issue 11414064: Ignore functions that have the same name as fields in gets and sets. (Closed)

Created:
8 years, 1 month ago by polux

Modified:
8 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Ignore functions that have the same name as fields in gets and sets. Committed: https://code.google.com/p/dart/source/detail?r=15525

Patch Set 5 : Use rihgt diffbase #

Total comments: 6

Patch Set 6 : Address Karl's comments and sync to 11348067 #

Patch Set 8 : extrapolate Karl's comment to getters #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -14 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1 2 3 4 5 6 7	4 chunks	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

polux

This is the famous PartialFunctionElement bug that has in fact nothing to do with partial ...

8 years, 1 month ago (2012-11-19 18:23:53 UTC) #1

karlklose

LGTM. https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1016 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1016: SourceString source) { source -> name. https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode1034 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1034: ...

8 years, 1 month ago (2012-11-21 09:10:02 UTC) #2

polux

8 years ago (2012-11-29 15:38:03 UTC) #3

https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/c...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/c...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1016:
SourceString source) {
On 2012/11/21 09:10:02, karlklose wrote:
> source -> name.

Done.

https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/c...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1034:
// since this is a set we ignore non-fields
On 2012/11/21 09:10:02, karlklose wrote:
> Perhaps you could call it a SendSet, setter-access, or something else
different
> from set, which could be confused with the datastructure.

Done.

https://chromiumcodereview.appspot.com/11414064/diff/9003/sdk/lib/_internal/c...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:1039:
Element classElem = member.getEnclosingClass();
On 2012/11/21 09:10:02, karlklose wrote:
>  if (!(member.isField() || member.isAbstractField()) continue?

Done.

Expand Messages | Collapse Messages