Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1484)

Issue 11414055: Revert "Allow tests to specify a package root." (Closed)

Created:
8 years, 1 month ago by ahe
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Allow tests to specify a package root." Revert "Add dependencies for bots that doesn't build everything." This reverts r15066 and r15064. Committed: https://code.google.com/p/dart/source/detail?r=15068

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -200 lines) Patch
M dart/dart.gyp View 4 chunks +0 lines, -15 lines 0 comments Download
M dart/pkg/args/test/args_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
D dart/pkg/pkg.gyp View 1 chunk +0 lines, -44 lines 0 comments Download
M dart/tests/standalone/package/package1_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/standalone/package/package_isolate_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M dart/tests/standalone/package/package_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
D dart/tools/make_links.py View 1 chunk +0 lines, -47 lines 0 comments Download
M dart/tools/testing/dart/test_suite.dart View 9 chunks +5 lines, -39 lines 0 comments Download
M dart/tools/testing/drt-trampoline.py View 1 chunk +18 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ahe
Something is really wrong: shutil.Error: [('/mnt/data/b/build/slave/dart2js-linux-release-1-5/build/dart/pkg/args/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib', '/mnt/data/b/build/slave/dart2js-linux-release-1-5/build/dart/out/ReleaseIA32/dart-sdk.tmp/pkg/args/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib/lib', "[Errno 40] Too many levels of symbolic links: ...
8 years, 1 month ago (2012-11-19 10:43:41 UTC) #1
ahe
TBR
8 years, 1 month ago (2012-11-19 10:44:45 UTC) #2
Mads Ager (google)
LGTM, urgh.
8 years, 1 month ago (2012-11-19 10:49:53 UTC) #3
ricow1
8 years, 1 month ago (2012-11-19 12:22:08 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698