Issue 11414044: Enable CurlClient tests on Windows by bundling curl.exe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11414044: Enable CurlClient tests on Windows by bundling curl.exe. (Closed)

Created:
8 years, 1 month ago by nweiz

Modified:
8 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable CurlClient tests on Windows by bundling curl.exe. BUG=6777 Committed: https://code.google.com/p/dart/source/detail?r=15117

Patch Set 2 : Certificate path #

Patch Set 3 : Really fix resource loading #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4049 lines, -13 lines)			Patch
A	third_party/curl/ca-certificates.crt	View		1 chunk	+3851 lines, -0 lines	0 comments	Download
A	third_party/curl/curl.LICENSE	View		1 chunk	+21 lines, -0 lines	0 comments	Download
A	third_party/curl/curl.exe	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A	third_party/curl/openssl.LICENSE	View		1 chunk	+126 lines, -0 lines	0 comments	Download
M	tools/create_sdk.py	View	1 2	1 chunk	+15 lines, -0 lines	2 comments	Download
M	utils/pub/curl_client.dart	View	1 2	4 chunks	+29 lines, -6 lines	0 comments	Download
M	utils/pub/io.dart	View	1 2	2 chunks	+8 lines, -5 lines	0 comments	Download
M	utils/tests/pub/pub.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One change. After that, LGTM! https://codereview.chromium.org/11414044/diff/5001/tools/create_sdk.py File tools/create_sdk.py (right): https://codereview.chromium.org/11414044/diff/5001/tools/create_sdk.py#newcode270 tools/create_sdk.py:270: ignore=ignore_patterns('.svn')) How about just ...

8 years, 1 month ago (2012-11-19 21:50:30 UTC) #2

nweiz

8 years, 1 month ago (2012-11-19 23:00:37 UTC) #3

https://codereview.chromium.org/11414044/diff/5001/tools/create_sdk.py
File tools/create_sdk.py (right):

https://codereview.chromium.org/11414044/diff/5001/tools/create_sdk.py#newcod...
tools/create_sdk.py:270: ignore=ignore_patterns('.svn'))
On 2012/11/19 21:50:30, Bob Nystrom wrote:
> How about just copying the needed files on non-Windows platforms? It will be
> really confusing if people see a .exe on their Mac SDK.

Done.