Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 11414019: Disallow const native factories (Closed)

Created:
8 years, 1 month ago by hausner
Modified:
8 years, 1 month ago
Reviewers:
regis
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Disallow const native factories We removed the only user of const native factory methods, so remove the hack in the VM. Issue 6662. Committed: https://code.google.com/p/dart/source/detail?r=14993

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M runtime/vm/parser.cc View 5 chunks +16 lines, -29 lines 0 comments Download
A tests/language/const_native_factory_test.dart View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hausner
8 years, 1 month ago (2012-11-16 00:38:41 UTC) #1
regis
8 years, 1 month ago (2012-11-16 00:47:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698