Roll NSS to 169195.

Roll NSS to 169195.

This updates NSS to version 3.14.

It also contains a fix for compiling with -O3 on GCC 4.6.3.

R=whesse@google.com
Committed: https://code.google.com/p/dart/source/detail?r=15278

[Bill Hesse, 2012-11-22 16:10:41]

LGTM, modulo the comment.

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/nss.gyp
File dart/runtime/bin/net/nss.gyp (right):

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/nss.gyp#...
dart/runtime/bin/net/nss.gyp:1158: ['exclude',
'<(nss_directory)/mozilla/security/nss/lib/libpkix/'],
The point of the comment is that we don't want to put the value of nss_directory
in the regexp that 'exclude' uses, since it won't work well.  Therefore we do a
partial match of the path, rather than an anchored match, starting with ^.
I don't think we should all <(nss_directory) here.  But the comment should be
here.

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/ssl.gyp
File dart/runtime/bin/net/ssl.gyp (right):

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/ssl.gyp#...
dart/runtime/bin/net/ssl.gyp:9: # This file is a modified copy of Chromium's
deps/third_party/nss/nss.gyp.
Good catch.

[Mads Ager (google), 2012-11-23 07:12:28]

Thanks!

https://codereview.chromium.org/11413141/diff/1/dart/runtime/tools/gyp/nss_co...
File dart/runtime/tools/gyp/nss_configurations.gypi (left):

https://codereview.chromium.org/11413141/diff/1/dart/runtime/tools/gyp/nss_co...
dart/runtime/tools/gyp/nss_configurations.gypi:40: # This flag would let a
certain assembly function be inlined,
YAY!

[Søren Gjesse, 2012-11-23 10:12:21]

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/nss.gyp
File dart/runtime/bin/net/nss.gyp (right):

https://codereview.chromium.org/11413141/diff/1/dart/runtime/bin/net/nss.gyp#...
dart/runtime/bin/net/nss.gyp:1158: ['exclude',
'<(nss_directory)/mozilla/security/nss/lib/libpkix/'],
On 2012/11/22 16:10:41, Bill Hesse wrote:
> The point of the comment is that we don't want to put the value of
nss_directory
> in the regexp that 'exclude' uses, since it won't work well.  Therefore we do
a
> partial match of the path, rather than an anchored match, starting with ^.
> I don't think we should all <(nss_directory) here.  But the comment should be
> here.

Good catch. Removed <(nss_directory)/ from the excludes.