Issue 11413138: Fix checked mode failures after List became an abstract class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11413138: Fix checked mode failures after List became an abstract class. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
Johnni Winther, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix checked mode failures after List became an abstract class. Committed: https://code.google.com/p/dart/source/detail?r=15243

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Anders Johnsen

Rubberstamp LGTM, I'm not entirely sure why it fixed it :)

8 years, 1 month ago (2012-11-22 08:35:34 UTC) #2

LGTM