Deprecating Element.elements for Element.children.

Deprecating Element.elements for Element.children.


BUG=3584
Committed: https://code.google.com/p/dart/source/detail?r=15118

[sra1, 2012-11-19 19:34:53]

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6790: List<Element> get elements {
get elements => this.children'

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6798: void set elements(value) {
set elements(value) { this.children = value; }

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6806: List<Element> _children;
_children needs an annotation:

@Creates('Null')  // Native field is used only by Dart code so does not lead to
instantiation of native classes

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6815: final children = this.children;
This is not the same set elements 
x.children = x.children;
will misbehave.

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:7646: List<Element> get elements => new
_ChildrenElementList._wrap(this);
I would write this as  => this.children

[Jacob, 2012-11-19 19:41:49]

lgtm

one random thought... 
i like 
element.children.add(new DivElement());
much better than 
element.elements.add(new DivElement());
but it is a bit confusing that I have to write
element.nodes.add(new Text("foo"));
Is there a reasonable way to make 
element.elements.add(new Text("foo")) not assert in checked mode?
e.g. make the signature for
ElementList.add be

void add(Node n) {
  parent.appendChild(n);
}

rather than
void add(Element n)  {
  parent.appendChild(n);
}

[blois, 2012-11-19 21:57:49]

Jacob-
Allowing elements.add(new Text('something')) would mean that we'd have to change
the return type from List<Element> to the custom collection.

Currently we have the addText method and I'd like to add add(Element) (or
append(Element) and appendText). Do you think this would be sufficient for the
scenario?

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6790: List<Element> get elements {
On 2012/11/19 19:34:53, sra1 wrote:
> get elements => this.children'

Done.

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6798: void set elements(value) {
On 2012/11/19 19:34:53, sra1 wrote:
> set elements(value) { this.children = value; }

Done.

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6806: List<Element> _children;
On 2012/11/19 19:34:53, sra1 wrote:
> _children needs an annotation:
> 
> @Creates('Null')  // Native field is used only by Dart code so does not lead
to
> instantiation of native classes

Done.

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:6815: final children = this.children;
On 2012/11/19 19:34:53, sra1 wrote:
> This is not the same set elements 
> x.children = x.children;
> will misbehave.

Done.

https://codereview.chromium.org/11413071/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:7646: List<Element> get elements => new
_ChildrenElementList._wrap(this);
On 2012/11/19 19:34:53, sra1 wrote:
> I would write this as  => this.children
> 

Done.

[sra1, 2012-11-19 22:16:34]

lgtm after moving the annotations to the right place.

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:6797: @Creates('Null')
This goes on the field '_children'.
Please include the comment, since it is a little obscure.

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:7643: @Creates('Null')
Remove.
Not needed on Dart code, only fields and methods marked as 'native'.

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:8984: void operator[]=(int index, num
value) { JS("void", "#[#] = #", this, index, value); }  // -- start List<num>
mixins.
What happened here?

[blois, 2012-11-19 22:58:53]

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:6797: @Creates('Null')
On 2012/11/19 22:16:34, sra1 wrote:
> This goes on the field '_children'.
> Please include the comment, since it is a little obscure.

Done.

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:7643: @Creates('Null')
On 2012/11/19 22:16:34, sra1 wrote:
> Remove.
> Not needed on Dart code, only fields and methods marked as 'native'.

Done.

https://codereview.chromium.org/11413071/diff/6001/sdk/lib/html/dart2js/html_...
sdk/lib/html/dart2js/html_dart2js.dart:8984: void operator[]=(int index, num
value) { JS("void", "#[#] = #", this, index, value); }  // -- start List<num>
mixins.
On 2012/11/19 22:16:34, sra1 wrote:
> What happened here?
Looks like the file was out of date. Sync'd and it looks good.

[Jacob, 2012-11-20 18:18:24]

lgtm

lgtm