Issue 11412258: Use the code point iterator when computing 16-bit string hash codes.

Issue 11412258: Use the code point iterator when computing 16-bit string hash codes. (Closed)

Created:
8 years ago by cshapiro

Modified:
8 years ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the code point iterator when computing 16-bit string hash codes. Committed: https://code.google.com/p/dart/source/detail?r=15565

Patch Set 2 : address review comments #

Patch Set 3 : bugfix #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -19 lines)			Patch
M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	3 chunks	+21 lines, -15 lines	0 comments	Download
M	runtime/vm/object_test.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	runtime/vm/unicode.h	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.cc#newcode10662 runtime/vm/object.cc:10662: } else { is this else necessary? it ...

8 years ago (2012-11-30 02:00:19 UTC) #2

cshapiro

8 years ago (2012-11-30 02:28:22 UTC) #3

https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.cc#newcode1...
runtime/vm/object.cc:10662: } else {
Strictly speaking, it is not.  I will remove it.

https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.h
File runtime/vm/object.h (right):

https://codereview.chromium.org/11412258/diff/1/runtime/vm/object.h#newcode3742
runtime/vm/object.h:3742: ASSERT(index_ != -1);
It was a remnant of an intermediate edit.  Reverted.

https://codereview.chromium.org/11412258/diff/1/runtime/vm/unicode.h
File runtime/vm/unicode.h (right):

https://codereview.chromium.org/11412258/diff/1/runtime/vm/unicode.h#newcode110
runtime/vm/unicode.h:110: }
Hmm... the code point iterator is rather bulky.  I think we can get away with
something smaller since we have the address of the character data.

Expand Messages | Collapse Messages