Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 11412242: Fix a use of native JS code to avoid substituting lvalues with '#'. (Closed)

Created:
8 years ago by erikcorry
Modified:
8 years ago
Reviewers:
ahe, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a use of native JS code to avoid substituting lvalues with '#'. The old version only worked because the optimization substituted this.fieldname for the getter. R=floitsch@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15511

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/lib/isolate_patch.dart View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
erikcorry
8 years ago (2012-11-29 09:41:04 UTC) #1
ahe
8 years ago (2012-11-29 09:58:27 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698