Issue 11412237: Fix dart_analyzer finding SDK after core_runtime.dart rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412237: Fix dart_analyzer finding SDK after core_runtime.dart rename (Closed)

Created:
8 years ago by Jennifer Messerly

Modified:
8 years ago

Reviewers:
dgrove, keertip

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart_analyzer after core_runtime.dart rename--it was having trouble finding the SDK if you didn't name your folder "dart-sdk". So it worked in the Editor, but not on buildbots that use the SDK like https://drone.io/. Also uses the same techique as "pub" to get the script directory. I think they had to harden it to handle symlinks and such. Committed: https://code.google.com/p/dart/source/detail?r=15563

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	compiler/scripts/dart_analyzer.bat	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	compiler/scripts/dart_analyzer.sh	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

Hopefully you guys have more context but the SDK doesn't have core_runtime anymore. "core.dart" seemed ...

8 years ago (2012-11-29 02:11:15 UTC) #2

LGTM! Thanks for the fix.

Expand Messages | Collapse Messages