Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 11412156: Fix for ClassCastException when [name] in comment uses import conflict name. (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for ClassCastException when [name] in comment uses import conflict name. Was in feedback logs. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -7 lines) Patch
M compiler/java/com/google/dart/compiler/ast/DartCommentRefName.java View 2 chunks +4 lines, -5 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 1 chunk +17 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/index/contributor/IndexContributor.java View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scheglov
8 years, 1 month ago (2012-11-23 20:54:30 UTC) #1
Brian Wilkerson
8 years ago (2012-11-26 14:59:13 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698