Issue 11412148: Fix handling of sends with wrong arity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11412148: Fix handling of sends with wrong arity (Closed)

Created:
8 years, 1 month ago by polux

Modified:
8 years ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix handling of sends with wrong arity Committed: https://code.google.com/p/dart/source/detail?r=15507

Patch Set 2 : Address Karl's comments #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -4 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	tests/compiler/dart2js/cpa_inference_test.dart	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM. https://codereview.chromium.org/11412148/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart (right): https://codereview.chromium.org/11412148/diff/1/sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart#newcode608 sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:608: argumentMap.forEach((Element parameter, ConcreteType type) { argumentMap.forEach(augmentParameterType)?

8 years ago (2012-11-28 08:04:08 UTC) #2

polux

8 years ago (2012-11-29 10:13:47 UTC) #3

https://codereview.chromium.org/11412148/diff/1/sdk/lib/_internal/compiler/im...
File
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart
(right):

https://codereview.chromium.org/11412148/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart:608:
argumentMap.forEach((Element parameter, ConcreteType type) {
On 2012/11/28 08:04:08, karlklose wrote:
> argumentMap.forEach(augmentParameterType)?

Done.

Expand Messages | Collapse Messages

Issue 11412148: Fix handling of sends with wrong arity (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address Karl's comments #

Messages