Support VTune's JIT interface.

Support VTune's JIT interface.

R=iposva@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=15517

[Ivan Posva, 2012-11-26 04:36:38]

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/tools/gyp/r...
File runtime/tools/gyp/runtime-configurations.gypi (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/tools/gyp/r...
runtime/tools/gyp/runtime-configurations.gypi:13: 'dart_vtune_root%':
'/opt/intel/vtune_amplifier_xe',
This default is very Linux specific, shouldn't it be added in some Linux
specific way?

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:7051: VTune::Register(name, instrs.EntryPoint(),
instrs.size());
We should really clean this up. The different tools should be supported outside
of this method in something like RegisterInTools. Does not have to happen in
this CL, but if you do not factor this out before the end of the week, please
file a tracking bug.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:7086: VTune::IsActive()) {
This seems rather error prone, as the checking is done at two places. Falls into
the same category as above.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/vm.gypi#...
runtime/vm/vm.gypi:61: ['OS=="linux" and dart_vtune_support == 1', {
I would prefer if we could find a way to deal with vtune without having to rerun
runhooks. If that is not possible fine, but we should explore the options.

[Vyacheslav Egorov (Google), 2012-11-26 15:11:10]

Please take another look.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/tools/gyp/r...
File runtime/tools/gyp/runtime-configurations.gypi (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/tools/gyp/r...
runtime/tools/gyp/runtime-configurations.gypi:13: 'dart_vtune_root%':
'/opt/intel/vtune_amplifier_xe',
On 2012/11/26 04:36:38, Ivan Posva wrote:
> This default is very Linux specific, shouldn't it be added in some Linux
> specific way?

I am open to suggestions on how to do that.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:7051: VTune::Register(name, instrs.EntryPoint(),
instrs.size());
On 2012/11/26 04:36:38, Ivan Posva wrote:
> We should really clean this up. The different tools should be supported
outside
> of this method in something like RegisterInTools. Does not have to happen in
> this CL, but if you do not factor this out before the end of the week, please
> file a tracking bug.

Refactored.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/object.c...
runtime/vm/object.cc:7086: VTune::IsActive()) {
On 2012/11/26 04:36:38, Ivan Posva wrote:
> This seems rather error prone, as the checking is done at two places. Falls
into
> the same category as above.

Refactored.

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://chromiumcodereview.appspot.com/11412106/diff/3001/runtime/vm/vm.gypi#...
runtime/vm/vm.gypi:61: ['OS=="linux" and dart_vtune_support == 1', {
On 2012/11/26 04:36:38, Ivan Posva wrote:
> I would prefer if we could find a way to deal with vtune without having to
rerun
> runhooks. If that is not possible fine, but we should explore the options.

Header file and library are required to enable support so unfortunately I don't
see how we can avoid reconfiguring compilation.

I am open to suggestions.

[Ivan Posva, 2012-11-27 09:11:20]

LGTM with comments.

-Ivan

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.cc#...
runtime/vm/dart.cc:206: sizeof(CodeObserver*) * code_observers_length_));  //
NOLINT
sizeof(observer) should make the lint warning go away.

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.cc#...
runtime/vm/dart.cc:294: // <name>_entry is used for code preceding the prolog
sequence.
prologue

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.cc#...
runtime/vm/dart.cc:295: // <name> for rest of the code (first instruction is
prolog sequence).
prologue

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.cc#...
runtime/vm/dart.cc:316: RegisterCodeObserver(new VTuneCodeObserver;
Does not compile).

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.h
File runtime/vm/dart.h (right):

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.h#n...
runtime/vm/dart.h:21: class CodeObserver {
I am not certain whether this belongs into this file or whether we should put it
into its own file code_observer.h and code_observer.cc. Can be split at a
different CL.

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/dart.h#n...
runtime/vm/dart.h:29: // Notify code observer about newly created code object
with the
about a newly

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/vtune.cc
File runtime/vm/vtune.cc (right):

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/vtune.cc...
runtime/vm/vtune.cc:34: bool VTuneCodeObserver::IsActive() const {
Do you even need to supply these UNREACHABLE methods if DART_VTUNE_SUPPORT is
not enabled?

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/vtune.h
File runtime/vm/vtune.h (right):

https://chromiumcodereview.appspot.com/11412106/diff/6003/runtime/vm/vtune.h#...
runtime/vm/vtune.h:12: class VTuneCodeObserver : public CodeObserver {
Do not even define this if DART_VTUNE_SUPPORT is not enabled?

[Vyacheslav Egorov (Google), 2012-11-27 16:26:11]

Please take another look. 

I've moved all observer related code to new files.

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.cc#newcode206
runtime/vm/dart.cc:206: sizeof(CodeObserver*) * code_observers_length_));  //
NOLINT
On 2012/11/27 09:11:20, Ivan Posva wrote:
> sizeof(observer) should make the lint warning go away.

Done.

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.cc#newcode316
runtime/vm/dart.cc:316: RegisterCodeObserver(new VTuneCodeObserver;
On 2012/11/27 09:11:20, Ivan Posva wrote:
> Does not compile).

Indeed. Fixed

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.h
File runtime/vm/dart.h (right):

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.h#newcode21
runtime/vm/dart.h:21: class CodeObserver {
On 2012/11/27 09:11:20, Ivan Posva wrote:
> I am not certain whether this belongs into this file or whether we should put
it
> into its own file code_observer.h and code_observer.cc. Can be split at a
> different CL.

Moved all code observers related code to a separate file code_observers.(cc|h).

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/dart.h#newcode29
runtime/vm/dart.h:29: // Notify code observer about newly created code object
with the
On 2012/11/27 09:11:20, Ivan Posva wrote:
> about a newly

Done.

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/vtune.cc
File runtime/vm/vtune.cc (right):

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/vtune.cc#newcode34
runtime/vm/vtune.cc:34: bool VTuneCodeObserver::IsActive() const {
On 2012/11/27 09:11:20, Ivan Posva wrote:
> Do you even need to supply these UNREACHABLE methods if DART_VTUNE_SUPPORT is
> not enabled?

Done.

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/vtune.h
File runtime/vm/vtune.h (right):

https://codereview.chromium.org/11412106/diff/6003/runtime/vm/vtune.h#newcode12
runtime/vm/vtune.h:12: class VTuneCodeObserver : public CodeObserver {
On 2012/11/27 09:11:20, Ivan Posva wrote:
> Do not even define this if DART_VTUNE_SUPPORT is not enabled?

Done.