Issue 11411356: Reduce debug printing from test script when testing --build-directory option.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411356: Reduce debug printing from test script when testing --build-directory option. (Closed)

Created:
8 years ago by Bill Hesse

Modified:
8 years ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reduce debug printing from test script when testing --build-directory option. Cleanup fix to mkdirRecursive. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15686

Patch Set 1 #

Patch Set 2 : Removed debugging code. #

Total comments: 1

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View	1	1 chunk	+6 lines, -7 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

karlklose

LGTM for the removed print, but you should find another reviewer for the actual path ...

8 years ago (2012-12-04 13:53:15 UTC) #2

Anton Muhin

8 years ago (2012-12-04 14:19:57 UTC) #4

lgtm

https://codereview.chromium.org/11411356/diff/2001/tools/testing/dart/test_su...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11411356/diff/2001/tools/testing/dart/test_su...
tools/testing/dart/test_suite.dart:1520: if (base.toString() == "/$segment" &&
this all looks ugly, maybe we should extend Path api to handle that more
directly

Expand Messages | Collapse Messages