Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 11411345: Another try. (Closed)

Created:
8 years ago by Anton Muhin
Modified:
8 years ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 2 (0 generated)
Anton Muhin
8 years ago (2012-12-04 01:47:44 UTC) #1
Bill Hesse
8 years ago (2012-12-04 12:36:55 UTC) #2
Message was sent while issue was closed.
I think this is working correctly now.  I think the remaining problems are in
other places, that are still manipulating paths as strings.  We should make the
createOutputDirectory function return a Path.

We should never need to add or remove or check slashes or backslashes by hand -
all we should need are Path.fromNative and Path.toNative and File.fromPath.

The general effect of toNative is:

Path = /E:/src/dart/build/Debug/foo/
native = E:\src\dart\build\Debug\foo\

https://codereview.chromium.org/11411345/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/11411345/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1520: base = new Path(segment);
I would use base = base.append(segment) here, like below.
Path('/').append('E:') is Path('/E:'), which is what you want as a path.  All
you want to do is skip the directory check and creation.

https://codereview.chromium.org/11411345/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1525: print("======= creating $dir $base");
I would put the debug printing just before the dir.createSync(), so you know
when that is being hit.

Powered by Google App Engine
This is Rietveld 408576698