Get curl uploads working on Mac.

Get curl uploads working on Mac.

Committed: https://code.google.com/p/dart/source/detail?r=15592

[Bob Nystrom, 2012-11-30 00:37:17]

This mostly works, but it fails this test:

'cloud storage upload provides an error'

#0      Configuration.onDone
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/src/config.dart:130:7)
#1      _completeTests
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/unittest.dart:835:17)
#2      _nextBatch._nextBatch
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/unittest.dart:818:17)
#3      _nextTestCase
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/unittest.dart:678:14)
#4      _handleCallbackFunctionComplete.<anonymous closure>
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/unittest.dart:669:22)
#5      _defer.<anonymous closure>
(file:///Users/rnystrom/dev/dart/dart/pkg/unittest/lib/unittest.dart:712:13)
#6      _ReceivePortImpl._handleMessage (dart:isolate-patch:37:92)

Command line: xcodebuild/ReleaseIA32/dart --ignore-unrecognized-flags
--package-root=xcodebuild/ReleaseIA32/packages/
/Users/rnystrom/dev/dart/dart/utils/tests/pub/pub_lish_test.dart

I'm sure I'm just failing to drain something or some other in the magic dance
you have to do to get a Process to shut down cleanly. Ideas?

[nweiz, 2012-11-30 01:19:45]

lgtm

https://codereview.chromium.org/11411273/diff/1002/utils/pub/curl_client.dart
File utils/pub/curl_client.dart (right):

https://codereview.chromium.org/11411273/diff/1002/utils/pub/curl_client.dart...
utils/pub/curl_client.dart:108: Future _waitForHeaders(Process process, {bool
expectBody}) {
If you're still going to call this "waitForHeaders", at least explain in the
documentation that it's necessary to wait for the process to terminate as well.

https://codereview.chromium.org/11411273/diff/1002/utils/tests/pub/pub_lish_t...
File utils/tests/pub/pub_lish_test.dart (right):

https://codereview.chromium.org/11411273/diff/1002/utils/tests/pub/pub_lish_t...
utils/tests/pub/pub_lish_test.dart:207: // TODO(rnystrom): HTTP requires that
you don't start sending a response
It's probably worth mentioning that curl will actually choke on this on OS X and
Windows.

[Bob Nystrom, 2012-11-30 01:42:44]

Thanks!

https://codereview.chromium.org/11411273/diff/1002/utils/pub/curl_client.dart
File utils/pub/curl_client.dart (right):

https://codereview.chromium.org/11411273/diff/1002/utils/pub/curl_client.dart...
utils/pub/curl_client.dart:108: Future _waitForHeaders(Process process, {bool
expectBody}) {
On 2012/11/30 01:19:45, nweiz wrote:
> If you're still going to call this "waitForHeaders", at least explain in the
> documentation that it's necessary to wait for the process to terminate as
well.

Added a comment explaining.

https://codereview.chromium.org/11411273/diff/1002/utils/tests/pub/pub_lish_t...
File utils/tests/pub/pub_lish_test.dart (right):

https://codereview.chromium.org/11411273/diff/1002/utils/tests/pub/pub_lish_t...
utils/tests/pub/pub_lish_test.dart:207: // TODO(rnystrom): HTTP requires that
you don't start sending a response
On 2012/11/30 01:19:45, nweiz wrote:
> It's probably worth mentioning that curl will actually choke on this on OS X
and
> Windows.

Done.