Issue 11411271: Remove support for interfaces.

Issue 11411271: Remove support for interfaces. (Closed)

Created:
8 years ago by regis

Modified:
8 years ago

Reviewers:
srdjan, hausner

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove support for interfaces. For now, disable tests using obsolete syntax. Tests disabled in this cl and in previous ones removing default factory classes will either be deleted or updated in a later cl. Committed: https://code.google.com/p/dart/source/detail?r=15562

Patch Set 1 #

Total comments: 10

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -512 lines)			Patch
M	runtime/include/dart_api.h	View	1	1 chunk	+2 lines, -16 lines	0 comments	Download
M	runtime/lib/mirrors.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/tests/vm/vm.status	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/class_finalizer.cc	View	1	3 chunks	+2 lines, -15 lines	0 comments	Download
M	runtime/vm/compiler.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	5 chunks	+16 lines, -16 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	2 chunks	+5 lines, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	2 chunks	+5 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier.h	View	1	2 chunks	+43 lines, -43 lines	0 comments	Download
M	runtime/vm/object.h	View	1	11 chunks	+7 lines, -38 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	14 chunks	+14 lines, -127 lines	0 comments	Download
M	runtime/vm/parser.h	View	1	7 chunks	+5 lines, -7 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	33 chunks	+19 lines, -216 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/token.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language.status	View	1	5 chunks	+119 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11411271/diff/1/runtime/vm/dart_api_impl_test.cc File runtime/vm/dart_api_impl_test.cc (right): https://codereview.chromium.org/11411271/diff/1/runtime/vm/dart_api_impl_test.cc#newcode2381 runtime/vm/dart_api_impl_test.cc:2381: #define CHECK_INTERFACE(handle, name) \ Shall this be called ...

8 years ago (2012-11-29 23:52:12 UTC) #2

regis

8 years ago (2012-11-30 00:24:30 UTC) #4

Thanks!

https://codereview.chromium.org/11411271/diff/1/runtime/vm/dart_api_impl_test.cc
File runtime/vm/dart_api_impl_test.cc (right):

https://codereview.chromium.org/11411271/diff/1/runtime/vm/dart_api_impl_test...
runtime/vm/dart_api_impl_test.cc:2381: #define CHECK_INTERFACE(handle, name)    
                              \
On 2012/11/29 23:52:12, srdjan wrote:
> Shall this be called CHECK_ABSTRACT_CLASS and check that it is an abstract
> class?

Done.

https://codereview.chromium.org/11411271/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_ia32.cc (right):

https://codereview.chromium.org/11411271/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_ia32.cc:134: // dynamic type argument.
On 2012/11/29 23:52:12, srdjan wrote:
> add: , only class check needed.

Done.

https://codereview.chromium.org/11411271/diff/1/runtime/vm/flow_graph_compile...
File runtime/vm/flow_graph_compiler_x64.cc (right):

https://codereview.chromium.org/11411271/diff/1/runtime/vm/flow_graph_compile...
runtime/vm/flow_graph_compiler_x64.cc:134: // dynamic type argument.
On 2012/11/29 23:52:12, srdjan wrote:
> ditto.

Done.

https://codereview.chromium.org/11411271/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11411271/diff/1/runtime/vm/object.cc#newcode1910
runtime/vm/object.cc:1910: set_state_bits(ImplementedBit::update(true,
raw_ptr()->state_bits_));
On 2012/11/29 23:52:12, srdjan wrote:
> Weird diff. Is set_is_implemented really twice in the source?

I do not see this duplication in the source.

https://codereview.chromium.org/11411271/diff/1/tests/language/language.status
File tests/language/language.status (right):

https://codereview.chromium.org/11411271/diff/1/tests/language/language.statu...
tests/language/language.status:62: generic_instanceof3_test: Fail, OK
On 2012/11/29 23:52:12, srdjan wrote:
> Ouch, that is a lot of tests that need to be updatet. Please update Issue 6324
> asking for someone to fix the tests

I'm going to do it, but I'll update the bug report anyway.

Expand Messages | Collapse Messages