Issue 11411215: Generate parameter stubs using ASTs.

Issue 11411215: Generate parameter stubs using ASTs. (Closed)

Created:
8 years ago by sra1

Modified:
8 years ago

Reviewers:
floitsch, ngeoffray

CC:
reviews_dartlang.org, erikcorry

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Generate parameter stubs using ASTs. Committed: https://code.google.com/p/dart/source/detail?r=15540

Patch Set 2 : #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -123 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/nodes.dart	View	1	1 chunk	+3 lines, -0 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	4 chunks	+29 lines, -33 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1	2 chunks	+104 lines, -36 lines	1 comment	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1	1 chunk	+0 lines, -44 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM! https://codereview.chromium.org/11411215/diff/6/sdk/lib/_internal/compiler/implementation/js/nodes.dart File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right): https://codereview.chromium.org/11411215/diff/6/sdk/lib/_internal/compiler/implementation/js/nodes.dart#newcode434 sdk/lib/_internal/compiler/implementation/js/nodes.dart:434: Call callOn(List<Expression> arguments) => new Call(this, arguments); I ...

8 years ago (2012-11-29 16:49:04 UTC) #2

sra1

https://codereview.chromium.org/11411215/diff/6/sdk/lib/_internal/compiler/implementation/js/nodes.dart File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right): https://codereview.chromium.org/11411215/diff/6/sdk/lib/_internal/compiler/implementation/js/nodes.dart#newcode434 sdk/lib/_internal/compiler/implementation/js/nodes.dart:434: Call callOn(List<Expression> arguments) => new Call(this, arguments); On 2012/11/29 ...

8 years ago (2012-11-29 20:39:09 UTC) #3

ngeoffray

8 years ago (2012-11-30 09:01:56 UTC) #4

Message was sent while issue was closed.

LGTM!

https://codereview.chromium.org/11411215/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js/nodes.dart (right):

https://codereview.chromium.org/11411215/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js/nodes.dart:434: Call
callWith(List<Expression> arguments) => new Call(this, arguments);
I prefer 'call' :)

https://codereview.chromium.org/11411215/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart
(right):

https://codereview.chromium.org/11411215/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart:217:
stubParameters.map((param) => param.name));
I would to this by hand to keep the order and then avoid the loop line 222.

Expand Messages | Collapse Messages