Issue 11411147: Address review comments on issue 11412105.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11411147: Address review comments on issue 11412105. (Closed)

Created:
8 years, 1 month ago by ngeoffray

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Address review comments on issue 11412105. Committed: https://code.google.com/p/dart/source/detail?r=15282

Patch Set 2 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -91 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View		7 chunks	+29 lines, -49 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1	2 chunks	+3 lines, -15 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/nodes.dart	View		7 chunks	+0 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://codereview.chromium.org/11411147/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right): https://codereview.chromium.org/11411147/diff/1/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart#newcode1727 sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1727: // The 'length' name should not be mangled. ...

8 years, 1 month ago (2012-11-23 13:05:03 UTC) #2

ngeoffray

8 years, 1 month ago (2012-11-23 13:07:52 UTC) #3

Thanks Peter.

https://codereview.chromium.org/11411147/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/ssa/codegen.dart (right):

https://codereview.chromium.org/11411147/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/ssa/codegen.dart:1727: // The 'length'
name should not be mangled.
On 2012/11/23 13:05:03, ahe wrote:
> But why? :-)

Done.

Expand Messages | Collapse Messages

Issue 11411147: Address review comments on issue 11412105. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages