Issue 11411119: Clean up warnings.

Issue 11411119: Clean up warnings. (Closed)

Created:
8 years, 1 month ago by karlklose

Modified:
8 years, 1 month ago

Reviewers:
Johnni Winther, ahe, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up warnings. Committed: https://code.google.com/p/dart/source/detail?r=15194

Patch Set 1 : #

Total comments: 5

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -7 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1 chunk	+2 lines, -1 line	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1181 sdk/lib/_internal/compiler/implementation/elements/elements.dart:1181: var target = defaultImplementation; I can't find which ...

8 years, 1 month ago (2012-11-21 10:22:11 UTC) #2

karlklose

Thanks, Nicolas! https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right): https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler/implementation/elements/elements.dart#newcode1181 sdk/lib/_internal/compiler/implementation/elements/elements.dart:1181: var target = defaultImplementation; target.defaultImplementation in the ...

8 years, 1 month ago (2012-11-21 11:33:32 UTC) #4

ahe

8 years, 1 month ago (2012-11-22 16:11:30 UTC) #5

LGTM!

https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/universe/universe.dart (right):

https://codereview.chromium.org/11411119/diff/1007/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/universe/universe.dart:438:
ClassElement classySelf = self;
LOL!

Expand Messages | Collapse Messages