Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 11411092: Revert "Add some support for the code-point code-unit distinction." (Closed)

Created:
8 years, 1 month ago by erikcorry
Modified:
8 years, 1 month ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Add some support for the code-point code-unit distinction." This reverts commit r15150 R=karlklose@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=15152

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+611 lines, -1012 lines) Patch
M runtime/lib/string.cc View 5 chunks +17 lines, -18 lines 0 comments Download
M runtime/lib/string_base.dart View 8 chunks +78 lines, -114 lines 0 comments Download
M runtime/lib/string_patch.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/dart_api_message.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 8 chunks +6 lines, -14 lines 0 comments Download
M runtime/vm/object.cc View 14 chunks +38 lines, -36 lines 0 comments Download
M runtime/vm/object_test.cc View 21 chunks +59 lines, -122 lines 0 comments Download
M runtime/vm/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/scanner.cc View 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.cc View 5 chunks +10 lines, -11 lines 0 comments Download
M runtime/vm/unicode.h View 5 chunks +9 lines, -37 lines 0 comments Download
M runtime/vm/unicode.cc View 12 chunks +21 lines, -34 lines 0 comments Download
M runtime/vm/unicode_test.cc View 85 chunks +172 lines, -172 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +15 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/core_patch.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_string.dart View 2 chunks +3 lines, -25 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/token.dart View 2 chunks +1 line, -9 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_map_builder.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/string_validator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
sdk/lib/_internal/compiler/implementation/util/util.dart View 1 chunk +40 lines, -54 lines 0 comments Download
M sdk/lib/core/string.dart View 3 chunks +18 lines, -97 lines 0 comments Download
sdk/lib/io/string_stream.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/uri/encode_decode.dart View 1 chunk +11 lines, -2 lines 0 comments Download
M sdk/lib/utf/utf32.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/utf/utf8.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/utf/utf_core.dart View 1 chunk +42 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 chunk +3 lines, -5 lines 0 comments Download
M tests/co19/co19-dart2js.status View 2 chunks +5 lines, -6 lines 0 comments Download
M tests/co19/co19-runtime.status View 2 chunks +4 lines, -6 lines 0 comments Download
tests/corelib/corelib.status View 3 chunks +1 line, -7 lines 0 comments Download
D tests/corelib/reg_exp_unicode_2_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/corelib/reg_exp_unicode_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M tests/corelib/string_from_list_test.dart View 1 chunk +4 lines, -25 lines 0 comments Download
D tests/corelib/string_trim_unicode_test.dart View 1 chunk +0 lines, -47 lines 0 comments Download
D tests/corelib/surrogate_pair_toUpper_test.dart View 1 chunk +0 lines, -64 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/io/string_stream_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/utils/utf8_test.dart View 2 chunks +10 lines, -6 lines 0 comments Download
M tests/utils/utf_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +1 line, -0 lines 0 comments Download
M utils/tests/string_encoding/unicode_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karlklose
LGTM.
8 years, 1 month ago (2012-11-20 15:17:58 UTC) #1
erikcorry
8 years, 1 month ago (2012-11-20 15:18:08 UTC) #2

          

Powered by Google App Engine
This is Rietveld 408576698