Issue 11411072: Simplify CodePatcher::GetStaticCallAt.

Issue 11411072: Simplify CodePatcher::GetStaticCallAt. (Closed)

Created:
8 years, 1 month ago by srdjan

Modified:
8 years, 1 month ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify CodePatcher::GetStaticCallAt. Committed: https://code.google.com/p/dart/source/detail?r=15101

Patch Set 3 : #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -51 lines)			Patch
M	runtime/vm/code_generator.cc	View	1 2	4 chunks	+23 lines, -20 lines	0 comments	Download
M	runtime/vm/code_patcher.h	View	1 2	1 chunk	+1 line, -4 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View	1 2	1 chunk	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/code_patcher_x64.cc	View	1 2	1 chunk	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/vm/native_entry_test.cc	View	1 2	1 chunk	+3 lines, -8 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

https://codereview.chromium.org/11411072/diff/1/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11411072/diff/1/runtime/vm/code_generator.cc#newcode792 runtime/vm/code_generator.cc:792: } The code above will be necessary in the ...

8 years, 1 month ago (2012-11-19 18:11:03 UTC) #1

regis

LGTM https://codereview.chromium.org/11411072/diff/5002/runtime/vm/code_generator.cc File runtime/vm/code_generator.cc (right): https://codereview.chromium.org/11411072/diff/5002/runtime/vm/code_generator.cc#newcode777 runtime/vm/code_generator.cc:777: // the target method. The comment states "called ...

8 years, 1 month ago (2012-11-19 18:35:18 UTC) #2

srdjan

8 years, 1 month ago (2012-11-19 19:15:44 UTC) #3

Thanks!

https://codereview.chromium.org/11411072/diff/5002/runtime/vm/code_generator.cc
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/11411072/diff/5002/runtime/vm/code_generator....
runtime/vm/code_generator.cc:777: // the target method.
On 2012/11/19 18:35:19, regis wrote:
> The comment states "called after compilation", but the compiler is invoked
below
> if the function has no code. Can you clarify the comment?

Removed that comment. The code is in transition.

https://codereview.chromium.org/11411072/diff/5002/runtime/vm/code_generator....
runtime/vm/code_generator.cc:1534: // Patch static call to point to
'new_entry_point'.
On 2012/11/19 18:35:19, regis wrote:
> What is 'new_entry_point'?
> A comment describing the arguments to this runtime call is missing. Both
runtime
> calls above are also missing a comment.

new_entry_point -> "valid code's entry point"
Next CL will remove arguments of both functions. Leaving it as is.

Expand Messages | Collapse Messages