Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 11410102: Undo bogus change to use old dart:io API. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom
Modified:
8 years, 1 month ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Undo bogus change to use old dart:io API. Committed: https://code.google.com/p/dart/source/detail?r=14928

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Bob Nystrom
Apparently I had an out-of-date editor, so when I fixed this warning, I actually fixed ...
8 years, 1 month ago (2012-11-14 23:29:34 UTC) #1
nweiz
8 years, 1 month ago (2012-11-14 23:31:45 UTC) #2
On 2012/11/14 23:29:34, Bob Nystrom wrote:
> Apparently I had an out-of-date editor, so when I fixed this warning, I
actually
> fixed it to the wrong older API. The previous code was correct.
> 
> TBR.

Oh, yeah, I made that mistake myself a while ago. Unfortunately I also couldn't
remember which way was correct while reviewing :p.

Powered by Google App Engine
This is Rietveld 408576698