Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 11410084: Change the xcode configuration file to use an overwritable variable (Closed)

Created:
8 years, 1 month ago by Mads Ager (google)
Modified:
8 years, 1 month ago
Reviewers:
ahe, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change the xcode configuration file to use an overwritable variable for the xcode gcc version. This allows me to build with xcode 4 without a local patch to build files by just creating overwrites in my ~/.gyp/include.gypi: { 'variables': { 'xcode_gcc_version': 'com.apple.compilers.llvmgcc42', 'mac_sdk': '10.7', 'mac_deployment_target': '10.7', } } R=ahe@google.com,iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M tools/gyp/configurations_xcode.gypi View 1 chunk +12 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 1 month ago (2012-11-14 11:08:29 UTC) #1
ahe
8 years, 1 month ago (2012-11-14 13:43:25 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698