Issue 11410013: Correct test status of arithmetic_test for dart2dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11410013: Correct test status of arithmetic_test for dart2dart. (Closed)

Created:
8 years, 1 month ago by Florian Schneider

Modified:
8 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Correct test status of arithmetic_test for dart2dart. It is only expected to fail with dart2js. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=14759

Patch Set 1 #

Total comments: 2

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tests/language/language_dart2js.status	View		1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

srdjan

LGTM https://codereview.chromium.org/11410013/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): https://codereview.chromium.org/11410013/diff/1/tests/language/language_dart2js.status#newcode36 tests/language/language_dart2js.status:36: arithmetic_test: Fail Move it then to line 92

8 years, 1 month ago (2012-11-09 21:16:17 UTC) #2

Florian Schneider

8 years, 1 month ago (2012-11-09 21:23:11 UTC) #3

https://codereview.chromium.org/11410013/diff/1/tests/language/language_dart2...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11410013/diff/1/tests/language/language_dart2...
tests/language/language_dart2js.status:36: arithmetic_test: Fail
On 2012/11/09 21:16:17, srdjan wrote:
> Move it then to line 92

Done.

Expand Messages | Collapse Messages