Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1140943005: Fix for invalidating results of a target being removed. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix for invalidating results of a target being removed. Tweaks for tests. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -51 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +32 lines, -34 lines 0 comments Download
M pkg/analyzer/lib/src/task/general.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/abstract_context.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 9 chunks +7 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-14 02:48:09 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-14 14:28:19 UTC) #2
scheglov
5 years, 7 months ago (2015-05-14 14:33:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698