Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11407002: Adding 'part of html' to all files which are used by dart:html. (Closed)

Created:
8 years, 1 month ago by blois
Modified:
8 years, 1 month ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding 'part of html' to all files which are used by dart:html. This came up during the code review of merging interfaces and implementations, that some of the files were missing the 'part of html' statements. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14690

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2871 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 528 chunks +2136 lines, -7 lines 1 comment Download
M sdk/lib/html/dartium/html_dartium.dart View 590 chunks +593 lines, -1 line 0 comments Download
M sdk/lib/html/src/CrossFrameTypes.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Device.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/EventListener.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Isolates.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/KeyCode.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/KeyLocation.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/KeyName.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Measurement.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/ReadyState.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Serialization.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/Timer.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/_Collections.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/_HttpRequestUtils.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/_ListIterators.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/_Lists.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/src/_Testing.dart View 2 chunks +3 lines, -1 line 0 comments Download
M sdk/lib/html/templates/dart2js_impl.darttemplate View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_AudioElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_Blob.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_CSSMatrix.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_DataView.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_FormData.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_MutationObserver.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_OptionElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_ShadowRoot.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_SharedWorker.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/factoryprovider_TextTrackCue.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_AudioBufferSourceNode.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_Console.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_ElementEvents.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_IDBDatabase.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_LocalWindow.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_SelectElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_TableElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dart2js/impl_Url.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/dart_implementation.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/factoryprovider.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/factoryprovider_HttpRequest.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/impl_LocalWindow.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_AudioContext.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_CanvasElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_CanvasRenderingContext2D.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_CustomEvent.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Document.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Element.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Event.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_EventTarget.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_HttpRequest.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_IDBKeyRange.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Node.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_NodeList.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Point.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_SVGElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_SVGSVGElement.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_ShadowRoot.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Storage.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_Text.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_WebSocket.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/html/templates/html/impl/pure_interface.darttemplate View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
blois
8 years, 1 month ago (2012-11-08 01:24:48 UTC) #1
Anton Muhin
8 years, 1 month ago (2012-11-08 07:02:11 UTC) #2 
lgtm

https://codereview.chromium.org/11407002/diff/1/sdk/lib/html/dart2js/html_dar...
File sdk/lib/html/dart2js/html_dart2js.dart (right):

https://codereview.chromium.org/11407002/diff/1/sdk/lib/html/dart2js/html_dar...
sdk/lib/html/dart2js/html_dart2js.dart:45: // Copyright (c) 2012, the Dart
project authors.  Please see the AUTHORS file
not for this CL, but I wonder if we should drop those copyright comments.

Powered by Google App Engine
This is Rietveld 408576698