Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 11405003: Update fixnum to new package guidelines. (Closed)

Created:
8 years, 1 month ago by Bob Nystrom
Modified:
8 years, 1 month ago
Reviewers:
financecoding, gram
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update fixnum to new package guidelines. BUG= Committed: https://code.google.com/p/dart/source/detail?r=14760

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move fixnum parts into src. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -1596 lines) Patch
D pkg/fixnum/fixnum.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/fixnum/int32.dart View 1 chunk +0 lines, -356 lines 0 comments Download
D pkg/fixnum/int64.dart View 1 chunk +0 lines, -1097 lines 0 comments Download
D pkg/fixnum/intx.dart View 1 chunk +0 lines, -105 lines 0 comments Download
A + pkg/fixnum/lib/fixnum.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + pkg/fixnum/lib/src/int32.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + pkg/fixnum/lib/src/int64.dart View 1 5 chunks +5 lines, -5 lines 0 comments Download
A + pkg/fixnum/lib/src/intx.dart View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/fixnum/test/int_32_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/fixnum/test/int_64_test.dart View 8 chunks +10 lines, -10 lines 0 comments Download
M pkg/fixnum/test/int_64_vm_test.dart View 1 6 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
8 years, 1 month ago (2012-11-09 02:04:57 UTC) #1
Adam
intx.dart, int32.dart, int64.dart should be in lib/src/ for package guide lines. Also the unit tests ...
8 years, 1 month ago (2012-11-09 08:26:49 UTC) #2
gram
lgtm https://codereview.chromium.org/11405003/diff/1/pkg/fixnum/test/int_64_vm_test.dart File pkg/fixnum/test/int_64_vm_test.dart (right): https://codereview.chromium.org/11405003/diff/1/pkg/fixnum/test/int_64_vm_test.dart#newcode11 pkg/fixnum/test/int_64_vm_test.dart:11: part '../lib/int64.dart'; Won't you have a problem here ...
8 years, 1 month ago (2012-11-09 18:35:55 UTC) #3
Bob Nystrom
On 2012/11/09 08:26:49, Adam wrote: > intx.dart, int32.dart, int64.dart should be in lib/src/ for package ...
8 years, 1 month ago (2012-11-09 21:21:46 UTC) #4
Bob Nystrom
8 years, 1 month ago (2012-11-09 21:23:17 UTC) #5
Thanks!

https://codereview.chromium.org/11405003/diff/1/pkg/fixnum/test/int_64_vm_tes...
File pkg/fixnum/test/int_64_vm_test.dart (right):

https://codereview.chromium.org/11405003/diff/1/pkg/fixnum/test/int_64_vm_tes...
pkg/fixnum/test/int_64_vm_test.dart:11: part '../lib/int64.dart';
On 2012/11/09 18:35:55, gram wrote:
> Won't you have a problem here later with 'part of' not matching the library
> name?

Yeah, we will. I tried making them sublibraries instead but this test (which has
to be manually run and has bit-rotted) accesses some private stuff in those
parts, unfortunately.

Right now, I'm just trying to get this to follow the new layout (in particular,
have its tests under test) so I can get "package:" imports working on the bots.

Powered by Google App Engine
This is Rietveld 408576698