Fix result type checking of redirecting factory in checked mode (issue 6596).

Fix result type checking of redirecting factory in checked mode (issue 6596).
Committed: https://code.google.com/p/dart/source/detail?r=14916

[hausner, 2012-11-14 19:47:32]

LGTM

[ahe, 2012-11-19 10:26:02]

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
tests/language/language_dart2js.status:99: factory_redirection_test/02: Crash
It would be great if you could report a bug when you find a crash in dart2js.

[regis, 2012-11-19 17:32:26]

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
tests/language/language_dart2js.status:99: factory_redirection_test/02: Crash
On 2012/11/19 10:26:02, ahe wrote:
> It would be great if you could report a bug when you find a crash in dart2js.

I did not, because several bugs are already filed against factory redirection
support in dart2js (incl. one crash bug), and because many
factory_redirection_test are failing. But this is done now:
issue 6799.

[ahe, 2012-11-19 17:50:11]

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
File tests/language/language_dart2js.status (right):

https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
tests/language/language_dart2js.status:99: factory_redirection_test/02: Crash
On 2012/11/19 17:32:26, regis wrote:
> I did not, because several bugs are already filed against factory redirection
> support in dart2js (incl. one crash bug), and because many
> factory_redirection_test are failing. But this is done now:
> issue 6799.

Thank you, Regis, I wasn't aware of any crashes until I filed 6791 earlier
today.  Would you mind pointing me to the other ones as I want to bump their
priority?

[regis, 2012-11-19 18:01:37]

On 2012/11/19 17:50:11, ahe wrote:
>
https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
> File tests/language/language_dart2js.status (right):
> 
>
https://codereview.chromium.org/11404004/diff/10001/tests/language/language_d...
> tests/language/language_dart2js.status:99: factory_redirection_test/02: Crash
> On 2012/11/19 17:32:26, regis wrote:
> > I did not, because several bugs are already filed against factory
redirection
> > support in dart2js (incl. one crash bug), and because many
> > factory_redirection_test are failing. But this is done now:
> > issue 6799.
> 
> Thank you, Regis, I wasn't aware of any crashes until I filed 6791 earlier
> today.  Would you mind pointing me to the other ones as I want to bump their
> priority?

OK, the crash bug came later. I saw it this morning when looking for the one I
saw last week: 6634, not a crash bug, though.

Cheers,
Regis