Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 1140373002: Convert two tests to use async/await. (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -51 lines) Patch
M pkg/analysis_server/test/edit/assists_test.dart View 2 chunks +14 lines, -17 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 3 chunks +31 lines, -34 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-18 15:58:35 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-18 16:00:21 UTC) #2
scheglov
5 years, 7 months ago (2015-05-18 16:51:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a8b7d1afe0f474c11e31230eb2f7e1fd29463699 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698