Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1140033003: Improve the browser suite timeout logic. (Closed)

Created:
5 years, 7 months ago by nweiz
Modified:
5 years, 7 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve the browser suite timeout logic. Don't wait for every suite to load at once—this basically ensures that once there are enough, later ones will time out. Instead, only load eight suites at once. Closes #102 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/e8d1f789686da0c4a3b9f9e75f60ca309debdddd

Patch Set 1 #

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M CHANGELOG.md View 1 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 3 chunks +28 lines, -16 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
nweiz
5 years, 7 months ago (2015-05-18 21:52:15 UTC) #1
kevmoo
lgtm
5 years, 7 months ago (2015-05-18 23:33:13 UTC) #2
kevmoo
On 2015/05/18 23:33:13, kevmoo wrote: > lgtm ...may also want to mark the pubspec as ...
5 years, 7 months ago (2015-05-18 23:33:31 UTC) #3
nweiz
Code review changes
5 years, 7 months ago (2015-05-19 00:44:08 UTC) #4
nweiz
5 years, 7 months ago (2015-05-19 00:48:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e8d1f789686da0c4a3b9f9e75f60ca309debdddd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698