Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1139793002: Fix status file and add accidentally removed test. (Closed)

Created:
5 years, 7 months ago by floitsch
Modified:
5 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Fix status file and add accidentally removed test. Committed: https://code.google.com/p/dart/source/detail?r=45712

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
A tests/isolate/deferred_in_isolate2_lib.dart View 1 chunk +1 line, -0 lines 1 comment Download
A tests/isolate/deferred_in_isolate2_test.dart View 1 chunk +21 lines, -0 lines 1 comment Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
TBR.
5 years, 7 months ago (2015-05-11 19:30:41 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 45712 (presubmit successful).
5 years, 7 months ago (2015-05-11 19:31:00 UTC) #3
Lasse Reichstein Nielsen
https://codereview.chromium.org/1139793002/diff/1/tests/isolate/deferred_in_isolate2_lib.dart File tests/isolate/deferred_in_isolate2_lib.dart (right): https://codereview.chromium.org/1139793002/diff/1/tests/isolate/deferred_in_isolate2_lib.dart#newcode1 tests/isolate/deferred_in_isolate2_lib.dart:1: String f() => "hi"; Add copyright header. Add comment ...
5 years, 7 months ago (2015-05-11 20:11:15 UTC) #4
floitsch
5 years, 7 months ago (2015-05-11 20:14:30 UTC) #5
Message was sent while issue was closed.
These were existing tests. (I had them deleted accidentally).
Will do the changes in a follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698