Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 1139693002: Compute better names for source maps. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, nweiz
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Compute better names for source maps. BUG=http://dartbug.com/23336 R=floitsch@google.com Committed: https://github.com/dart-lang/sdk/commit/e4d3c4339dc0ec2c1131c079fcedff503edb6eb1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -16 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 5 chunks +35 lines, -4 lines 0 comments Download
A tests/compiler/dart2js/source_map_name_test.dart View 1 chunk +165 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/source_map_validator_helper.dart View 3 chunks +58 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-11 09:06:34 UTC) #2
Johnni Winther
ping
5 years, 7 months ago (2015-05-18 08:06:54 UTC) #3
floitsch
LGTM.
5 years, 7 months ago (2015-05-18 08:52:24 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-19 13:00:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e4d3c4339dc0ec2c1131c079fcedff503edb6eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698