Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1139643004: Add AnalysisCache.getState() and getValue(). (Closed)

Created:
5 years, 7 months ago by scheglov
Modified:
5 years, 7 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Add AnalysisCache.getState() and getValue(). There is a small functionality change, I think a valid one. We don't check is the value is valid, we ask the CacheEntry, which updates the flush manager. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=45710

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -41 lines) Patch
M pkg/analyzer/lib/src/context/cache.dart View 1 chunk +28 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 10 chunks +19 lines, -39 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart_work_manager.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 7 months ago (2015-05-11 19:13:09 UTC) #1
Brian Wilkerson
LGTM
5 years, 7 months ago (2015-05-11 19:22:28 UTC) #2
scheglov
5 years, 7 months ago (2015-05-11 19:26:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45710 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698