Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1139503002: Move 'dart:profiler' contents into 'dart:developer' and remove 'dart:profiler' (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
kevmoo, Ivan Posva
CC:
reviews_dartlang.org, ricow1, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Move 'dart:profiler' contents into 'dart:developer' and remove 'dart:profiler' BUG= R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -590 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/developer_sources.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/lib/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
D runtime/lib/profiler_sources.gypi View 1 chunk +0 lines, -13 lines 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +0 lines, -2 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 2 chunks +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +6 lines, -5 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +0 lines, -6 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +0 lines, -88 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + sdk/lib/developer/profiler.dart View 1 chunk +1 line, -3 lines 0 comments Download
D sdk/lib/profiler/profiler.dart View 1 chunk +0 lines, -200 lines 0 comments Download
D sdk/lib/profiler/profiler_sources.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M tests/compiler/dart2js/incremental/compile_all.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/developer/metrics_num_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/developer/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/developer/user_tags_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/lib.status View 2 chunks +3 lines, -3 lines 0 comments Download
D tests/lib/profiler/metrics_num_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/profiler/metrics_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D tests/lib/profiler/user_tags_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Cutch
5 years, 7 months ago (2015-05-08 22:22:49 UTC) #2
kevmoo
This is a breaking change, right? Could we make the library as deprecated for a ...
5 years, 7 months ago (2015-05-08 22:43:59 UTC) #4
Cutch
On 2015/05/08 22:43:59, kevmoo wrote: > This is a breaking change, right? > > Could ...
5 years, 7 months ago (2015-05-08 22:52:32 UTC) #5
Cutch
PTAL
5 years, 7 months ago (2015-05-13 19:37:36 UTC) #6
kevmoo
On 2015/05/13 19:37:36, Cutch wrote: > PTAL Is there a delta?
5 years, 7 months ago (2015-05-13 19:38:49 UTC) #7
Ivan Posva
LGTM + Δ -Ivan
5 years, 7 months ago (2015-05-13 23:02:46 UTC) #8
Cutch
5 years, 7 months ago (2015-05-13 23:48:53 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 45783 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698