Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 113943007: Added convenience function for reading status file expectations (Closed)

Created:
6 years, 11 months ago by kustermann
Modified:
6 years, 11 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added convenience function for reading status file expectations R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=31472

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -57 lines) Patch
M dart/tools/testing/dart/status_file_parser.dart View 2 chunks +15 lines, -5 lines 2 comments Download
M dart/tools/testing/dart/test_suite.dart View 4 chunks +29 lines, -52 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
6 years, 11 months ago (2014-01-02 15:37:40 UTC) #1
ricow1
lgtm https://codereview.chromium.org/113943007/diff/1/dart/tools/testing/dart/status_file_parser.dart File dart/tools/testing/dart/status_file_parser.dart (right): https://codereview.chromium.org/113943007/diff/1/dart/tools/testing/dart/status_file_parser.dart#newcode157 dart/tools/testing/dart/status_file_parser.dart:157: void ReadConfigurationInto(path, sections, onDone) { while you are ...
6 years, 11 months ago (2014-01-06 13:25:18 UTC) #2
kustermann
https://codereview.chromium.org/113943007/diff/1/dart/tools/testing/dart/status_file_parser.dart File dart/tools/testing/dart/status_file_parser.dart (right): https://codereview.chromium.org/113943007/diff/1/dart/tools/testing/dart/status_file_parser.dart#newcode157 dart/tools/testing/dart/status_file_parser.dart:157: void ReadConfigurationInto(path, sections, onDone) { On 2014/01/06 13:25:19, ricow1 ...
6 years, 11 months ago (2014-01-06 13:56:32 UTC) #3
kustermann
6 years, 11 months ago (2014-01-06 13:57:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31472 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698