Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 113943002: Mark failing tests on chromeOnAndroid platform. (Closed)

Created:
7 years ago by Bill Hesse
Modified:
7 years ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark failing dart2js_extra isolate test on chromeOnAndroid platform. Mark two flaky tests with timeouts. BUG=dartbug.com/14458 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=31096

Patch Set 1 #

Patch Set 2 : Remove extra space #

Patch Set 3 : Add some flaky timeouts to status files, file issue for them. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years ago (2013-12-12 12:45:05 UTC) #1
kustermann
lgtm Are the same tests timing out or is it every time a different timeout? ...
7 years ago (2013-12-12 13:16:07 UTC) #2
Bill Hesse
On 2013/12/12 13:16:07, kustermann wrote: > lgtm > > Are the same tests timing out ...
7 years ago (2013-12-12 13:19:19 UTC) #3
Bill Hesse
7 years ago (2013-12-12 14:24:13 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r31096 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698