Issue 1139403002: VM: Clean up ARM/MIPS breakpoint patching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1139403002: VM: Clean up ARM/MIPS breakpoint patching (Closed)

Created:
5 years, 7 months ago by Florian Schneider

Modified:
5 years, 7 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

VM: Clean up ARM/MIPS breakpoint patching No WriteableInstructionScope needed since the code is not changed (only the constant pool). BUG= R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/8ce63e2fae483b6edd1a11907d29bfa17452ddfb

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -82 lines)			Patch
	M	runtime/vm/debugger_arm.cc	View		2 chunks	+27 lines, -41 lines	0 comments	Download
	M	runtime/vm/debugger_mips.cc	View		2 chunks	+27 lines, -41 lines	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

5 years, 7 months ago (2015-05-19 08:50:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8ce63e2fae483b6edd1a11907d29bfa17452ddfb (presubmit successful).