Issue 113923004: Only store the address bytes for an internet address in Dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 113923004: Only store the address bytes for an internet address in Dart (Closed)

Created:
7 years ago by Søren Gjesse

Modified:
7 years ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Only store the address bytes for an internet address in Dart We used to store the full C "struct sockaddr_storage" in the Dart internet address. Changed this to be only the bytes for the address. This removes opaque platform specific binary data from Dart (e.g. on Mac OS the "struct sockaddr" has an initial length byte). R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31191

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+143 lines, -168 lines)			Patch
M	runtime/bin/io_natives.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	runtime/bin/secure_socket.cc	View	1 chunk	+1 line, -10 lines	0 comments	Download
M	runtime/bin/socket.h	View	3 chunks	+56 lines, -4 lines	0 comments	Download
M	runtime/bin/socket.cc	View	11 chunks	+35 lines, -92 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	16 chunks	+49 lines, -59 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

7 years ago (2013-12-17 15:35:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r31191 (presubmit successful).

Expand Messages | Collapse Messages