Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1139163004: Store FP instead of SP in the exit info when transitioning from Dart to C++. (Closed)

Created:
5 years, 7 months ago by Florian Schneider
Modified:
5 years, 7 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store FP instead of SP in the exit info when transitioning from Dart to C++. The exit frame info should contain the FP, not SP. This only worked so far because FP == SP in the three exit-stubs affected (CallToRuntime-, CallNativeCFunction-, CallBootstrapCFunction-stub). This change has no performance implications but allows to set up a general frame (frame size > 0) in those stubs if needed. BUG= R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/d7c38331634bcbc8664138aea3fe1d77352bc945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M runtime/vm/stub_code_arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Florian Schneider
5 years, 7 months ago (2015-05-19 12:05:22 UTC) #2
srdjan
lgtm
5 years, 7 months ago (2015-05-19 14:58:19 UTC) #3
Cutch
On 2015/05/19 14:58:19, srdjan wrote: > lgtm What kind of frame are you planning on ...
5 years, 7 months ago (2015-05-19 15:35:10 UTC) #4
Florian Schneider
On 2015/05/19 15:35:10, Cutch wrote: > On 2015/05/19 14:58:19, srdjan wrote: > > lgtm > ...
5 years, 7 months ago (2015-05-19 15:51:00 UTC) #5
Florian Schneider
5 years, 7 months ago (2015-05-20 08:23:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7c38331634bcbc8664138aea3fe1d77352bc945 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698