Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1138993005: Revert 45783 (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, ricow1, turnidge, vm-dev_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -460 lines) Patch
M pkg/analyzer/lib/src/generated/utilities_general.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dart2js_incremental/lib/dart2js_incremental.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/developer_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/lib/profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/lib/profiler_sources.gypi View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/native_metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/ui/inspector.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/method_recognizer.h View 1 chunk +5 lines, -6 lines 0 comments Download
M runtime/vm/method_recognizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/object.cc View 3 chunks +15 lines, -10 lines 0 comments Download
M runtime/vm/object_store.h View 4 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/object_store.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 6 chunks +88 lines, -0 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/developer/developer_sources.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D sdk/lib/developer/profiler.dart View 1 chunk +0 lines, -198 lines 0 comments Download
A + sdk/lib/profiler/profiler.dart View 1 chunk +3 lines, -1 line 0 comments Download
A + sdk/lib/profiler/profiler_sources.gypi View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/incremental/compile_all.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/lib/developer/metrics_num_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/lib/developer/metrics_test.dart View 1 chunk +0 lines, -114 lines 0 comments Download
D tests/lib/developer/user_tags_test.dart View 1 chunk +0 lines, -82 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +3 lines, -3 lines 0 comments Download
A + tests/lib/profiler/metrics_num_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/profiler/metrics_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/lib/profiler/user_tags_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
TBR
5 years, 7 months ago (2015-05-14 00:31:58 UTC) #2
Cutch
Committed patchset #1 (id:1) manually as 45784 (presubmit successful).
5 years, 7 months ago (2015-05-14 00:33:35 UTC) #3
Ivan Posva
5 years, 7 months ago (2015-05-14 04:38:57 UTC) #4
Message was sent while issue was closed. 
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698