Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1138963005: Fix exception in code completion (issue 23439) (Closed)

Created:
5 years, 7 months ago by Brian Wilkerson
Modified:
5 years, 7 months ago
Reviewers:
lukechurch, danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix exception in code completion (issue 23439) R=danrubel@google.com Committed: https://code.google.com/p/dart/source/detail?r=45805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 chunk +4 lines, -1 line 0 comments Download
A pkg/analysis_server/test/services/completion/local_declaration_visitor_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 7 months ago (2015-05-14 18:39:29 UTC) #2
danrubel
lgtm
5 years, 7 months ago (2015-05-14 22:25:03 UTC) #3
Brian Wilkerson
5 years, 7 months ago (2015-05-15 00:01:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45805 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698